Skip to content

replace 'Courier New' with 'monospace' in Linux font list#34947

Merged
Tyriar merged 1 commit intomicrosoft:masterfrom
andyli:linux-monospace
Oct 2, 2017
Merged

replace 'Courier New' with 'monospace' in Linux font list#34947
Tyriar merged 1 commit intomicrosoft:masterfrom
andyli:linux-monospace

Conversation

@andyli
Copy link
Contributor

@andyli andyli commented Sep 25, 2017

A workaround better than #33319.

Close #5742.

@mention-bot
Copy link

@andyli, thanks for your PR! By analyzing the history of the files in this pull request, we identified @alexandrudima and @rebornix to be potential reviewers.

@jhasse
Copy link
Contributor

jhasse commented Sep 26, 2017

I've tested it on Fedora 26 and it works as intended: 'monospace' results in Liberation Mono just as 'Courier New' did. The problem is that if Courier New is really installed, it will look terrible (I guess because it was designed with Windows' hinting algorithm in mind, not FreeType's), see #5742 (comment). @Tyriar mentioned that monospace doesn't help, but according to #5742 (comment) that seems to be a Chromium bug and should be fixed by adding single-quotes around it just like this PR does :)

@Tyriar Tyriar self-requested a review September 26, 2017 18:07
@alexdima alexdima self-requested a review September 27, 2017 09:23
Copy link
Member

@alexdima alexdima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexdima
Copy link
Member

@Tyriar I see you would also like to test things out. This PR looks good to me. Please feel free to merge once you had a chance to review.

@alexdima alexdima assigned Tyriar and unassigned alexdima Sep 27, 2017
@Tyriar
Copy link
Member

Tyriar commented Sep 27, 2017

Yes I wanted to test this on a few distros to verify, targeting October 😃

@Tyriar Tyriar added this to the October 2017 milestone Sep 27, 2017
@Tyriar Tyriar merged commit cdd2de7 into microsoft:master Oct 2, 2017
@andyli andyli deleted the linux-monospace branch October 6, 2017 02:09
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Default font on Ubuntu looks terrible (should we ship a font with vscode?)

5 participants