Skip to content

Fixed issue of Illegal git value for line#34781

Merged
joaomoreno merged 2 commits intomicrosoft:masterfrom
Jeyanthinath:git_line_fix
Dec 11, 2017
Merged

Fixed issue of Illegal git value for line#34781
joaomoreno merged 2 commits intomicrosoft:masterfrom
Jeyanthinath:git_line_fix

Conversation

@Jeyanthinath
Copy link
Contributor

fix vscode #32681

Copy link
Member

@jrieken jrieken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't remove/weaken the assertion but make sure that the calling side provides correct argument values.

@jrieken jrieken requested a review from joaomoreno September 25, 2017 06:52
@jrieken jrieken assigned joaomoreno and unassigned jrieken Sep 25, 2017
@joaomoreno joaomoreno added this to the Backlog milestone Sep 25, 2017
@joaomoreno joaomoreno merged commit 282afd5 into microsoft:master Dec 11, 2017
@joaomoreno joaomoreno modified the milestones: Backlog, December 2017 Dec 11, 2017
@joaomoreno joaomoreno added the git GIT issues label Dec 11, 2017
@joaomoreno
Copy link
Member

Thanks! 🍻

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

git GIT issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants