agentHost: honor managed Assisted approval verdicts by rwoll · Pull Request #341889 · microsoft/vscode

Ross Wollman (rwoll) · 2026-10-15T23:17:39Z

Forward the SDK's derived permission prompt so an approving Assisted verdict permits a managed request once without prompting. Preserve managed one-time restrictions and sandbox safeguards.

ls now properly goes through to the judge and deny is still respected:

🤖 Authored with GitHub Copilot on behalf of Ross Wollman (@rwoll).

Bundle runtime 1.0.99-1 for desktop and remote. Refresh the managed telemetry schema and assisted-permission recordings for the new judge requests. Preserve tool-call reference mapping and JSON diff escapes in recordings without relaxing strict replay or human-approval assertions. Co-authored-by: Copilot <[email protected]>

Normalize quoted JSON path values without changing escaped file content, and apply the same normalization when comparing recorded and live requests. Cover Windows paths in fenced, indented, and unfenced JSON while retaining negative controls for authored text, permission markers, tool wiring, and diff content. Co-authored-by: Copilot <[email protected]>

Treat the optional separator before a workdir/home placeholder as part of the path, matching Windows a/C:/... prefixes to POSIX a/... captures. Preserve exact diff hunks, authored content, and strict replay with focused cross-platform regression tests. Co-authored-by: Copilot <[email protected]>

Pick up the upstream bottom-panel geometry correction needed by packaged unit tests without changing SDK upgrade behavior. Co-authored-by: Copilot <[email protected]>

Bound placeholder paths at whitespace so subsequent authored expressions cannot be normalized into false matches. Preserve JSON escape spelling outside path tokens instead of parsing and reserializing entire quoted strings. Add external record/replay regression coverage for prose, embedded JSON, Windows paths, literal backslashes and Unicode escape distinctions. Co-authored-by: Copilot <[email protected]>

@rwoll

Consume the derived SDK permission prompt without weakening managed one-time approval or sandbox safeguards. Fixes #341390. 🤖 Authored with GitHub Copilot on behalf of @rwoll. Co-authored-by: Copilot <[email protected]>

Copilot

🔵 Needs a closer look

Security-sensitive permission correlation and the bundled runtime update need human review and cross-platform validation.

1 open finding

Cached approval verdict can leak across permission requests · New

What changed in this PR

Updates Agent Host to honor Assisted approvals for managed requests, addressing #341390 while retaining one-time approval and sandbox restrictions.

Changes:

Forwards SDK permission context and consumes derived Assisted verdicts.
Updates SDK/runtime dependencies and managed-permission tests.
Improves replay normalization for permission-judge requests.

File	Description
src/vs/platform/agentHost/test/node/modelRequestProjection.test.ts	Tests cross-platform diff prefixes.
src/vs/platform/agentHost/test/node/e2e/README.md	Documents replay normalization.
src/vs/platform/agentHost/test/node/e2e/providers/copilotManagedSettingsAgentHostE2E.integrationTest.ts	Updates Assisted expectations and tool-count assertions.
src/vs/platform/agentHost/test/node/e2e/harness/modelRequestProjection.ts	Normalizes placeholder path prefixes.
src/vs/platform/agentHost/test/node/e2e/harness/capiReplayProxy.ts	Normalizes judge references and path separators.
src/vs/platform/agentHost/test/node/e2e/captures/copilotcli-managed-write-denial-prevents-mutation-under-assisted.yaml	Records judge denial.
src/vs/platform/agentHost/test/node/e2e/captures/copilotcli-managed-write-approval-remains-one-time-under-assisted.yaml	Records separate write approvals.
src/vs/platform/agentHost/test/node/e2e/captures/copilotcli-managed-read-approval-remains-one-time-under-assisted.yaml	Records separate read approvals.
src/vs/platform/agentHost/test/node/copilotSessionLauncher.test.ts	Verifies permission-context forwarding.
src/vs/platform/agentHost/test/node/copilotAgentSession.test.ts	Tests managed approvals and conservative fallbacks.
src/vs/platform/agentHost/test/node/capiReplayProxyPathNormalization.test.ts	Tests authored-backslash preservation.
src/vs/platform/agentHost/test/node/capiReplayProxy.test.ts	Tests judge-reference normalization.
src/vs/platform/agentHost/test/node/__snapshots__/Copilot_SDK_-_managed_settings_bundled_managedSettings_schema_matches_the_snapshot.schema.json	Refreshes bundled schema snapshot.
src/vs/platform/agentHost/node/copilot/copilotSessionLauncher.ts	Forwards SDK callback context.
src/vs/platform/agentHost/node/copilot/copilotAgentSession.ts	Uses derived managed Assisted verdicts.
remote/package.json	Updates remote SDK/runtime versions.
remote/package-lock.json	Locks remote SDK packages.
package.json	Updates SDK/runtime versions.
package-lock.json	Locks updated SDK packages.
.github/skills/policy-and-managed-settings/sdk-runtime-policy.md	Clarifies managed Assisted approval rules.

Files not reviewed (1)

remote/package-lock.json: Generated file

🧠 Review effort: Balanced

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Ross Wollman (rwoll) · 2026-10-16T21:07:11Z

+			const autoApproval = canUseAssistedApproval && this._lastAppliedPermissionMode === 'assisted'
+				? managedApprovalRequired ? promptRequest?.assistedApproval : await this._takeAutoApproval(toolCallId)


Working on addressing this as it's valid.

Fixed in 28a3153. Both managed and unmanaged Assisted decisions now use only the current callback verdict; the tool-call-level approval cache and waiters are removed. Permission events remain for telemetry and sandbox bookkeeping.

Added the delayed-event regression for requireApproval, missing verdict, and missing callback context. All three reproduced the stale approval before the fix and pass afterward.

Before pushing: the exact Compile & Hygiene workflow command, full-repository ESLint, build typecheck, and cyclic-dependency checks passed; 1,327 unit tests and 12 managed-settings E2E replay tests passed. Also consolidated the inherited duplicate import causing the current CI ESLint failure.

🤖 Authored with GitHub Copilot on behalf of Ross Wollman (@rwoll).

@rwoll

Preserve upstream SDK/runtime versions, schema snapshot and unrelated changes while retaining the managed Assisted consumer fix. 🤖 Authored with GitHub Copilot on behalf of @rwoll. Co-authored-by: Copilot <[email protected]>

@rwoll

Include the concurrently landed changeset comparison fix; the tree is unchanged from the validated merge. 🤖 Authored with GitHub Copilot on behalf of @rwoll. Co-authored-by: Copilot <[email protected]>

github-actions · 2026-10-16T20:47:52Z

Screenshot Changes

Base: a7e1fc08 Current: d892138d

Changed (1)

sessions/sessionActivityBar/sessionActivityBar/SubmenuOpen/Light

Before	After

@rwoll

Fix TS1117 blocking Compile & Hygiene after merging main. 🤖 Authored with GitHub Copilot on behalf of @rwoll. Co-authored-by: Copilot <[email protected]>

@rwoll

Remove tool-call-level approval caching so a managed approval cannot authorize a later unmanaged permission request. Cover delayed events and missing callback verdicts, and preserve sandbox and managed one-shot guards. Consolidate the duplicate AgentService import inherited from main that was blocking the PR ESLint check. 🤖 Authored with GitHub Copilot on behalf of @rwoll. Co-authored-by: Copilot <[email protected]>

roblourens and others added 6 commits October 15, 2026 13:30

Merge origin/main for packaged panel fix (Written by Copilot)

9dd4a17

Pick up the upstream bottom-panel geometry correction needed by packaged unit tests without changing SDK upgrade behavior. Co-authored-by: Copilot <[email protected]>

agentHost: honor managed Assisted approval verdicts

7914e2d

Consume the derived SDK permission prompt without weakening managed one-time approval or sandbox safeguards. Fixes #341390. 🤖 Authored with GitHub Copilot on behalf of @rwoll. Co-authored-by: Copilot <[email protected]>

Base automatically changed from roblou/agents/bump-copilot-sdk-version to main October 15, 2026 23:49

Ross Wollman (rwoll) marked this pull request as ready for review October 16, 2026 00:08

Copilot AI balanced review requested due to automatic review settings October 16, 2026 00:08

Ross Wollman (rwoll) enabled auto-merge October 16, 2026 00:08

Copilot started reviewing on behalf of Ross Wollman (rwoll) October 16, 2026 00:09

View session

Copilot AI reviewed Oct 16, 2026

View reviewed changes

roblourens approved these changes Oct 16, 2026

View reviewed changes

roblourens previously approved these changes Oct 16, 2026

View reviewed changes

Dmitriy Vasyura (dmitrivMS) previously approved these changes Oct 16, 2026

View reviewed changes

vs-code-engineering Bot assigned Ross Wollman (rwoll) Oct 16, 2026

Merge main into managed Assisted permission fix

999e7bf

Preserve upstream SDK/runtime versions, schema snapshot and unrelated changes while retaining the managed Assisted consumer fix. 🤖 Authored with GitHub Copilot on behalf of @rwoll. Co-authored-by: Copilot <[email protected]>

Ross Wollman (rwoll) dismissed stale reviews from Dmitriy Vasyura (dmitrivMS) and roblourens via 999e7bf October 16, 2026 20:42

Merge latest main ancestry without changing validated sources

55bffe9

Include the concurrently landed changeset comparison fix; the tree is unchanged from the validated merge. 🤖 Authored with GitHub Copilot on behalf of @rwoll. Co-authored-by: Copilot <[email protected]>

test: remove duplicate gitService from Git-state fixture

b39b916

Fix TS1117 blocking Compile & Hygiene after merging main. 🤖 Authored with GitHub Copilot on behalf of @rwoll. Co-authored-by: Copilot <[email protected]>

Ross Wollman (rwoll) disabled auto-merge October 16, 2026 21:07

Justin Chen (justschen) approved these changes Oct 16, 2026

View reviewed changes

Karthik Nadig (karthiknadig) approved these changes Oct 16, 2026

View reviewed changes

Ross Wollman (rwoll) merged commit a32f4c9 into main Oct 16, 2026
49 checks passed

Ross Wollman (rwoll) deleted the agents/fix-managed-assisted-permissions branch October 16, 2026 22:05

vs-code-engineering Bot added this to the 1.143.0 milestone Oct 16, 2026

vs-code-engineering Bot mentioned this pull request Oct 16, 2026

Assisted Permissions mode in Enterprise Managed environments not working alongside disableBypassPermissionsMode #341390

Closed

Alexandru Dima (alexdima) mentioned this pull request Oct 16, 2026

sessions: fix stuck Cloud tasks in shared sandbox environments #342189

Merged

roblourens mentioned this pull request Oct 16, 2026

agentHost: bump Copilot SDK to 1.0.23-preview.4 #342199

Closed

Ross Wollman (rwoll) mentioned this pull request Oct 19, 2026

docs: add 1.143 enterprise release notes microsoft/vscode-docs#10511

Merged

roblourens mentioned this pull request Oct 20, 2026

agentHost: expand runtime E2E and enterprise tests #340216

Draft

Eliel Vipata (elielvipata) mentioned this pull request Oct 23, 2026

Reconstruct batch 108/124: 2026-10-15 → 2026-10-16 (agenthost, sessions, chat, search) TechnicalPlaygroundOrg/vscode#108

Open

Navigation Menu

Repository navigation

agentHost: honor managed Assisted approval verdicts - #341889

agentHost: honor managed Assisted approval verdicts#341889
Ross Wollman (rwoll) merged 10 commits into
mainfrom
agents/fix-managed-assisted-permissions

Ross Wollman (rwoll) commented Oct 15, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Ross Wollman (rwoll) Oct 16, 2026

Uh oh!

Ross Wollman (rwoll) Oct 16, 2026

Uh oh!

github-actions Bot commented Oct 16, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

		const autoApproval = canUseAssistedApproval && this._lastAppliedPermissionMode === 'assisted'
		? managedApprovalRequired ? promptRequest?.assistedApproval : await this._takeAutoApproval(toolCallId)

Conversation

Ross Wollman (rwoll) commented Oct 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

Ross Wollman (rwoll) Oct 16, 2026

Choose a reason for hiding this comment

Uh oh!

Ross Wollman (rwoll) Oct 16, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Oct 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Screenshot Changes

Changed (1)

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Ross Wollman (rwoll) commented Oct 15, 2026 •

edited

Loading

github-actions Bot commented Oct 16, 2026 •

edited

Loading