Skip to content

Support for uninstalling extensions given paths to their .vsix files#34042

Merged
joaomoreno merged 2 commits intomicrosoft:masterfrom
fabiospampinato:fix-33106
Nov 10, 2017
Merged

Support for uninstalling extensions given paths to their .vsix files#34042
joaomoreno merged 2 commits intomicrosoft:masterfrom
fabiospampinato:fix-33106

Conversation

@fabiospampinato
Copy link
Contributor

Fix for #33106.

I tried to touch as few things as possible and to reuse already available functions. Is it good enough?

I got a /Users/fabio/Dropbox/Projects/vscode/src/vs/code/node/cliProcessMain.ts is not formatted trying to commit the changes, I've no idea what that means.

@joaomoreno
Copy link
Member

I got a /Users/fabio/Dropbox/Projects/vscode/src/vs/code/node/cliProcessMain.ts is not formatted trying to commit the changes, I've no idea what that means.

It means you should run Format Document before staging. In the team we all have "editor.formatOnSave": true in order to have the files always formatted.

@joaomoreno joaomoreno added this to the Backlog milestone Sep 11, 2017
@fabiospampinato
Copy link
Contributor Author

Thanks for the info.

It should be properly formatted now.

@microsoft microsoft deleted a comment from msftclas Sep 26, 2017
@microsoft microsoft deleted a comment from msftclas Sep 26, 2017
@fabiospampinato
Copy link
Contributor Author

@joaomoreno Is this PR going to get merged anytime soon?

@joaomoreno joaomoreno modified the milestones: Backlog, November 2017 Nov 10, 2017
@joaomoreno joaomoreno merged commit 38589d4 into microsoft:master Nov 10, 2017
@joaomoreno
Copy link
Member

joaomoreno commented Nov 10, 2017

Thanks! 🍻

(Big PR backlog!)

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants