Add DejaVu and Noto as fallback Linux fonts.#33319
Add DejaVu and Noto as fallback Linux fonts.#33319andyli wants to merge 1 commit intomicrosoft:masterfrom
Conversation
Close microsoft#5742. This PR enable to use of fallback fonts before font bundling (suggested in microsoft#26893) is implemented.
|
@andyli, thanks for your PR! By analyzing the history of the files in this pull request, we identified @alexandrudima and @rebornix to be potential reviewers. |
|
@andyli, |
|
I'm against this since it removes the incentive for Ubuntu/Chromium to fix the underlying issue. See #5742 (comment) Also note that you've added the fonts before |
I still think that a simple workaround is better than waiting for a complete solution for ages. Note that the original issue (#5742) is created for over an year. And I don't see any real progress in #5742 either.
This is intentional as #5742 mentioned Courier New is very different from the first preference, Droid Sans Mono. It was even suggested to remove Courier New from the list. |
|
Good points. Wouldn't removing |
|
I'm happy to remove Courier New since I'm no fan of it anyway. However, Courier New is also in the lists of default fonts for Windows and Mac, so removing it may also affect those in some sense. If any of you really care, it can be done in another PR. |
|
|
For my computer, it looks exactly the same. Probably once Courier New is installed it became the default font for monospace... |
|
Or maybe it's the bug mentioned here: #5742 (comment) |
|
Ah, indeed, putting monospace in single quotes did make it use DejaVu Sans Mono which is the one I installed. |
|
Nice :) I would then suggest for the constant. What do you think? |
|
Yes, it sounds better than adding extra fallbacks. |
Close #5742.
This PR enable to use of fallback fonts before font bundling (suggested in #26893) is implemented.