Repository navigation
Ship stable symbol tool descriptions - #315686
Merged
Bhavya U (bhavyaus) merged 2 commits intoMay 11, 2026
Merged
Bhavya U (bhavyaus) merged 2 commits into
Bhavya U (bhavyaus) merged 2 commits into
Conversation
Make the cache-stable symbol tool behavior the default by always registering rename and usages tools with static descriptions. Remove the experimental setting now that the treatment is shipping. Co-authored-by: Copilot <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes the vscode_renameSymbol and vscode_listCodeUsages chat tools always publish byte-stable (provider-independent) tool descriptions, removing the previous experiment flag and updating tests to reflect the new default behavior.
Changes:
- Remove the
chat.experimental.symbolTools.cacheStableexperiment and its settings registration. - Make Rename/Usages tool descriptions static and stop re-registering tools based on provider changes.
- Update tool tests to assert provider-independent descriptions and default always-available tool data.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/test/browser/tools/usagesTool.test.ts | Updates expectations to always return tool data and to assert the description no longer lists languages. |
| src/vs/workbench/contrib/chat/test/browser/tools/renameTool.test.ts | Mirrors the UsagesTool test updates for rename, asserting description stability and always-present tool data. |
| src/vs/workbench/contrib/chat/common/constants.ts | Removes the ChatConfiguration.SymbolToolsCacheStable setting key. |
| src/vs/workbench/contrib/chat/browser/tools/usagesTool.ts | Makes tool data always static and removes provider-change-driven tool re-registration logic. |
| src/vs/workbench/contrib/chat/browser/tools/renameTool.ts | Same as usages tool: static tool data and simplified one-time registration. |
| src/vs/workbench/contrib/chat/browser/chat.contribution.ts | Removes the configuration registry entry for the deleted experiment setting. |
Copilot's findings
- Files reviewed: 6/6 changed files
- Comments generated: 0
Empty commit to rerun PR checks after an infrastructure setup failure. Co-authored-by: Copilot <[email protected]>
Bhavya U (bhavyaus)
added
~release-cherry-pick
Bhavya U (bhavyaus)
enabled auto-merge (squash)
May 11, 2026 17:43
Contributor
|
This PR will be automatically cherry-picked to |
Michael Lively (Yoyokrazy)
approved these changes
May 11, 2026
vs-code-engineering
Bot
added
release-cherry-pick
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We saw some nice cache improvements from freezing the tool description and keeping these symbol tools registered in our A/B. This is to ship the change.
chat.experimental.symbolTools.cacheStablenow that the treatment behavior is shipping