Repository navigation
chat: hide plugin actions for synced customization items - #315320
Merged
joshspicer merged 1 commit intoMay 8, 2026
Merged
Conversation
Items that come from the 'vscode-synced-customization' scheme are backed by a synthetic plugin that is purely an implementation detail of the sync mechanism. Showing 'Show Plugin' and 'Uninstall Plugin' context menu actions for those items is confusing because the plugin concept is not user-facing in that context. Tighten WHEN_ITEM_IS_PLUGIN to also require that the plugin URI does NOT start with the 'vscode-synced-customization:' scheme, so all three plugin-related menu items (inline trash icon, 'Uninstall Plugin', and 'Show Plugin') are suppressed for synced customization entries. Fixes: #314879 Co-authored-by: Copilot <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the AI Customization management UI so that plugin-specific context menu actions are not shown for synced customization items, which are internally represented via a synthetic plugin under the vscode-synced-customization: scheme.
Changes:
- Tighten the
WHEN_ITEM_IS_PLUGINwhen-clause to exclude items whose plugin URI uses the synced customization scheme. - Reuse the refined when-clause across all plugin-related menu contributions (“Show Plugin”, “Uninstall Plugin”, and the inline uninstall/trash action).
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/aiCustomization/aiCustomizationManagement.contribution.ts | Refines plugin item visibility logic to suppress plugin actions for synced customization entries by checking the plugin URI scheme. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
roblourens
approved these changes
May 8, 2026
Will Pfleger (wpfleger96)
added a commit
to wpfleger96/vscode
that referenced
this pull request
May 8, 2026
…2-not-clearing-terminal-title * upstream/main: chat: hide plugin actions for synced customization items (microsoft#315320) fixes microsoft#291188 (microsoft#314713) sessions: restore last active session on reload (microsoft#315312) Replace "Agents app" with "Agents window" in user-facing strings (microsoft#315302) chat: remove 'Bridged' badge from MCP servers in AI Customizations UI (microsoft#315319) Add proposal for custom editor diff/merge priority agentHost: revert undefined-field omission, update tests instead sessions: fix Customizations single-entry width overflow (microsoft#315125) agentHost: rewrite Resource attachments and omit undefined fields agentHost: support image and blob user-message attachments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #314879
What
Items from the
vscode-synced-customization:scheme are backed by a synthetic plugin — purely an implementation detail of the sync mechanism. Surfacing "Show Plugin" and "Uninstall Plugin" context menu actions for those items is confusing because the plugin concept is not user-facing in this context.How
Tightened
WHEN_ITEM_IS_PLUGINto also require that the item's plugin URI does not match thevscode-synced-customization:scheme. Since all three plugin-related menu registrations (inlinetrash icon,4_modify"Uninstall Plugin",1_open"Show Plugin") use this single constant, the suppression is automatic for synced customization entries.Regular (non-synced) plugin items are unaffected.