Repository navigation
fixes https://github.com/microsoft/vscode/issues/291188 - #314713
Merged
Megan Rogge (meganrogge) merged 1 commit intoMay 8, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses #291188 by changing how VS Code saves dirty editors before running (and rerunning) tasks so that save participants (e.g., format-on-save and codeActionsOnSave) run as expected, matching the behavior users see when starting a debug session.
Changes:
- Update task “save before run” to use an explicit save reason so formatting/code actions run during the pre-task save.
- Update task rerun flow to use the same explicit save reason when saving dirty editors.
Megan Rogge (meganrogge)
approved these changes
May 8, 2026
Megan Rogge (meganrogge)
left a comment
Megan Rogge (meganrogge)
left a comment
Collaborator
There was a problem hiding this comment.
Thanks!
Megan Rogge (meganrogge)
enabled auto-merge (squash)
May 8, 2026 16:34
roblourens
approved these changes
May 8, 2026
Megan Rogge (meganrogge)
merged commit May 8, 2026
25035fb
into
microsoft:main
29 of 30 checks passed
Will Pfleger (wpfleger96)
added a commit
to wpfleger96/vscode
that referenced
this pull request
May 8, 2026
…2-not-clearing-terminal-title * upstream/main: chat: hide plugin actions for synced customization items (microsoft#315320) fixes microsoft#291188 (microsoft#314713) sessions: restore last active session on reload (microsoft#315312) Replace "Agents app" with "Agents window" in user-facing strings (microsoft#315302) chat: remove 'Bridged' badge from MCP servers in AI Customizations UI (microsoft#315319) Add proposal for custom editor diff/merge priority agentHost: revert undefined-field omission, update tests instead sessions: fix Customizations single-entry width overflow (microsoft#315125) agentHost: rewrite Resource attachments and omit undefined fields agentHost: support image and blob user-message attachments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #291188.
How to test: