Repository navigation
Put ambiguous options into interface - #313953
Merged
Megan Rogge (meganrogge) merged 2 commits intoMay 4, 2026
Merged
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree company="Cursor" |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the terminal tabs list renderer to group related visibility callbacks into a dedicated options interface. It is a small internal cleanup in the terminal workbench UI that improves the renderer constructor’s API without changing behavior.
Changes:
- Replaced two separate renderer callback parameters with a single
ITerminalTabsRendererOptionsobject. - Updated renderer construction and usage sites to read
hasTextandhasActionBarthrough the new interface. - Added a small local interface to make the renderer’s visibility-related dependencies more explicit.
Anthony Kim (anthonykim1)
approved these changes
May 4, 2026
Contributor
|
Hello and thank you :)) |
Johannes Rieken (jrieken)
approved these changes
May 4, 2026
Contributor
Author
|
@microsoft-github-policy-service agree company="Cursor" |
Contributor
Author
|
Anthony Kim (@anthonykim1) cla bot might be having problems? |
Megan Rogge (meganrogge)
enabled auto-merge (squash)
May 4, 2026 21:41
Megan Rogge (meganrogge)
merged commit May 4, 2026
c75e862
into
microsoft:main
24 of 26 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc Megan Rogge (@meganrogge) Anthony Kim (@anthonykim1)