Repository navigation
fix(agentHost): await dbClose to resolve flaky session database tests - #313810
Merged
Connor Peet (connor4312) merged 3 commits intoMay 4, 2026
Merged
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses flakiness in SessionDatabase unit tests by ensuring the underlying SQLite connection is fully closed before subsequent tests run, avoiding file-lock race conditions in the agent host platform layer.
Changes:
- Await SQLite database closure by switching
db.close()to the existing promise wrapperdbClose(db)inSessionDatabase.close(). - Re-enable the previously skipped regression test for
getFileEdits([])returning an empty array.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/vs/platform/agentHost/node/sessionDatabase.ts |
Ensures close() truly awaits SQLite connection shutdown by using dbClose(db). |
src/vs/platform/agentHost/test/node/sessionDatabase.test.ts |
Re-enables the previously skipped flaky test case after the close race is addressed. |
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
Connor Peet (connor4312)
enabled auto-merge (squash)
May 4, 2026 15:03
Henning Dieterichs (hediet)
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a flaky test issue in the
SessionDatabasemodule (#306057). The root cause was an un-awaiteddb.close()call, which led to race conditions where a database file might still be locked when the next test case started.Changes
db.close()withdbClose(db)insessionDatabase.tsto ensure the asynchronous database closure is properly awaited.nullvalues from the database, ensuring they are accurately represented in TypeScript.'returns empty array when given empty array'test case which was previously skipped due to flakiness.Verification
scripts/test.sh --grep "SessionDatabase"on WSL2 with Node v22.Fixes #306057