notebook: fix unused cell lookup and broken selection deduplication#305105
Merged
amunger merged 2 commits intomicrosoft:mainfrom Mar 27, 2026
Merged
notebook: fix unused cell lookup and broken selection deduplication#305105amunger merged 2 commits intomicrosoft:mainfrom
amunger merged 2 commits intomicrosoft:mainfrom
Conversation
…en selection dedup
amunger
approved these changes
Mar 26, 2026
Collaborator
|
thanks for the clean-up |
bpasero
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Three independent issues
notebookEditorWidget.ts:3061:this.viewModel?.viewCells.find(...)performs an O(n) linear scan whose result is never assigned, the cell was already resolved via the O(1)getCellByHandle()call on the previous line.notebookEditorWidget.ts:3068+3074:cell.outputsViewModels.indexOf(key)is called twice for the same key: once for an existence check and again to retrieve the index.notebookViewModelImpl.ts:163:selectionHandlesgetter creates aSet<number>for deduplication but never callsadd(), so the Set stays empty and deduplication has no effect.Fix
viewCells.find()call.indexOfresult and use it for both the existence check and the offset calculation. Return early when the output is gone.handlesSet.add(cell.handle)call.