Fix operator precedence in fuzzyScore2 test assertion#304449
Merged
bpasero merged 2 commits intomicrosoft:mainfrom Mar 25, 2026
Merged
Fix operator precedence in fuzzyScore2 test assertion#304449bpasero merged 2 commits intomicrosoft:mainfrom
bpasero merged 2 commits intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a false-positive assertion in the fuzzy scoring unit tests by correcting operator precedence so the intended >= comparison is always evaluated.
Changes:
- Parenthesized
(multiScore ?? 0)inassert.ok(...)to ensure??is applied before>=.
|
bpasero
approved these changes
Mar 25, 2026
joaomoreno
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #304448
The
>=operator (precedence 11) binds tighter than??(precedence 5), somultiScore ?? 0 >= (sum)parses asmultiScore ?? (0 >= sum). WhenmultiScoreis a positive number,??short-circuits andassert.ok(positiveNumber)always passes without evaluating the comparison.Before:
assert.ok(multiScore ?? 0 >= ((firstSingleScore ?? 0) + (secondSingleScore ?? 0)))After:
assert.ok((multiScore ?? 0) >= ((firstSingleScore ?? 0) + (secondSingleScore ?? 0)))