settings: use local StopWatch to avoid timing corruption between concurrent searches#304361
Merged
rzhao271 merged 1 commit intomicrosoft:mainfrom Mar 24, 2026
Merged
Conversation
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @rzhao271Matched files:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes search telemetry timing in the Settings editor by removing the shared StopWatch instance that could be reset by overlapping local/remote/AI searches, and instead measuring each provider call with its own local stopwatch.
Changes:
- Removed the
stopWatchclass field to avoid shared state across concurrent searches. - Introduced per-call
StopWatchinstances in both AI LLM-ranked search and provider-backed preference searches. - Updated elapsed-time logging to use the local stopwatch values.
rzhao271
approved these changes
Mar 24, 2026
roblourens
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The settings editor uses a shared class-level
StopWatchinstance for measuring search duration telemetry. When AI search runs concurrently with local/remote searches (launched viacreateCancelablePromisewithout await), a new search can callstopWatch.reset()while a previous search is still timing, producing incorrect elapsed values.Fix
Replace the shared member variable with local
StopWatchinstances ingetLLMRankedResults()andsearchWithProvider(). Each search path gets its own timer.