browser: prevent new tab from flashing in quick pick#304297
Merged
jruales merged 2 commits intomicrosoft:mainfrom Mar 24, 2026
Merged
browser: prevent new tab from flashing in quick pick#304297jruales merged 2 commits intomicrosoft:mainfrom
jruales merged 2 commits intomicrosoft:mainfrom
Conversation
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @kycutlerMatched files:
@jrualesMatched files:
|
jruales
approved these changes
Mar 24, 2026
kycutler
approved these changes
Mar 24, 2026
Contributor
|
Looks great @jonathanrao99, thanks so much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #304217
Summary
When selecting "New Tab" from the browser tab quick pick, the newly created editor could briefly appear in the quick pick before it closed.
This change hides the quick pick immediately after logging telemetry and before opening the new editor, preventing listeners from rebuilding the items list while the quick pick is still visible.
Testing