Revert "Use bracketed paste for multiline executed terminal text (#302526)"#304134
Merged
meganrogge merged 2 commits intomainfrom Mar 23, 2026
Merged
Revert "Use bracketed paste for multiline executed terminal text (#302526)"#304134meganrogge merged 2 commits intomainfrom
meganrogge merged 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Reverts the earlier change that automatically wrapped any sendText containing \r/\n in bracketed paste mode, due to a regression impacting workbench.action.terminal.sendSequence (eg sending \u000D to simulate Enter in Git Bash).
Changes:
- Restore
TerminalInstance.sendTextto only apply bracketed paste when explicitly requested via thebracketedPasteModeargument. - Update
TerminalInstancebrowser tests to reflect the revert (including removal of tests added with the reverted change).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/vs/workbench/contrib/terminal/browser/terminalInstance.ts |
Stops auto-enabling bracketed paste for any text containing \r/\n; only wraps when explicitly requested. |
src/vs/workbench/contrib/terminal/test/browser/terminalInstance.test.ts |
Adjusts the TerminalInstance env test setup/waiting logic and removes bracketed-paste-related test coverage. |
Tyriar
approved these changes
Mar 23, 2026
meganrogge
added a commit
that referenced
this pull request
Mar 23, 2026
meganrogge
added a commit
that referenced
this pull request
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 58757c0.
We need a more focused fix to avoid issues like #303665, targeting only the
runInTerminalinvocations ofsendText.cc @jcansdale