Editor - fix paste preference filter matching all providers#304044
Merged
rzhao271 merged 1 commit intomicrosoft:mainfrom Mar 23, 2026
Merged
Editor - fix paste preference filter matching all providers#304044rzhao271 merged 1 commit intomicrosoft:mainfrom
rzhao271 merged 1 commit intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes paste preference filtering in the editor’s drop/paste controller so that the 'preferences' filter actually matches against a provider’s declared paste kinds instead of always matching all providers.
Changes:
- Corrected
providerMatchesPreference()for'preferences'to iterateprovider.providedPasteEditKindsin the outer loop (mirrors the'only'branch behavior).
rzhao271
approved these changes
Mar 23, 2026
DonJayamanne
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix paste preference provider filter that always matches every provider.
Problem
In
providerMatchesPreference(), the'preferences'branch iteratespreference.preferencesin both its outer and inner.some()loops. SinceHierarchicalKind.contains()is reflexive, this always returns true when preferences is non-empty -- every provider passes the filter regardless of what kinds it provides.The
'only'branch correctly iteratesprovider.providedPasteEditKindsin the outer loop.Fix
Change the outer
.some()to iterateprovider.providedPasteEditKinds, matching the'only'branch pattern.