Settings editor - avoid repeated extension list refresh#303957
Merged
rzhao271 merged 1 commit intomicrosoft:mainfrom Mar 27, 2026
Merged
Settings editor - avoid repeated extension list refresh#303957rzhao271 merged 1 commit intomicrosoft:mainfrom
rzhao271 merged 1 commit intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes SettingsEditor2.onConfigUpdate() by reducing redundant calls to refreshInstalledExtensionsList() (and therefore extensionManagementService.getInstalled()) when processing recommended extensions for the Settings editor.
Changes:
- Move
await this.refreshInstalledExtensionsList()out of the per-recommended-extension loop so it runs once peronConfigUpdate()invocation. - Update inline comments to describe the new refresh behavior.
src/vs/workbench/contrib/preferences/browser/settingsEditor2.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/preferences/browser/settingsEditor2.ts
Outdated
Show resolved
Hide resolved
xingsy97
force-pushed
the
wt/settings-refresh-outside-loop
branch
from
ba1dbd9 to
7a6de9f
Compare
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @rzhao271Matched files:
|
xingsy97
changed the title
xingsy97
force-pushed
the
wt/settings-refresh-outside-loop
branch
from
7a6de9f to
420b149
Compare
rzhao271
approved these changes
Mar 27, 2026
bpasero
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move
refreshInstalledExtensionsList()from inside the recommended-extensions loop to before it.Problem
In
onConfigUpdate(), the loop overtoggleData.settingsEditorRecommendedExtensionscallsawait this.refreshInstalledExtensionsList()on every iteration. This method callsextensionManagementService.getInstalled()(full IPC roundtrip) to fetch all installed extensions.The installed extension list does not change between loop iterations, so N recommended extensions produce N identical IPC calls.
Fix
Call
refreshInstalledExtensionsList()once before the loop. This still prevents the race between concurrentonConfigUpdatecalls (the original comment's concern) while avoiding redundant IPC.