fix: prevent duplicate tip nodes on re-entrant renderGettingStartedTipIfNeeded#302317
Merged
meganrogge merged 2 commits intomicrosoft:mainfrom Mar 17, 2026
Merged
fix: prevent duplicate tip nodes on re-entrant renderGettingStartedTipIfNeeded#302317meganrogge merged 2 commits intomicrosoft:mainfrom
meganrogge merged 2 commits intomicrosoft:mainfrom
Conversation
sathvikc
force-pushed
the
fix-duplicate-tips
branch
from
f83c2e7 to
d9eaba6
Compare
meganrogge
approved these changes
Mar 17, 2026
Collaborator
meganrogge
left a comment
meganrogge
left a comment
There was a problem hiding this comment.
Thanks! Saw one report of this, but wasn't able to repro.
bpasero
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
renderGettingStartedTipIfNeeded_gettingStartedTipPartguard assignment before the DOM append so re-entrant calls see the guard and return earlydom.clearNode(tipContainer)before append as a defensive measure against stale nodesRoot Cause
When
ChatTipContentPartis constructed, context-key changes can synchronously trigger another call torenderGettingStartedTipIfNeeded. The guard (this._gettingStartedTipPart.value) was set aftertipContainer.appendChild(), so the re-entrant call would pass the guard check, create a second tip, and append it -producing the "multiple identical tips stacked" symptom.Fix
Reorder the method so that:
this._gettingStartedTipPart.value = store) is set before any DOM mutationdom.clearNode(tipContainer)clears any stale nodes before appending the new tip