Chat - remove deprecated prompt attribute spelling#301976
Merged
pwang347 merged 2 commits intomicrosoft:mainfrom Mar 26, 2026
Merged
Chat - remove deprecated prompt attribute spelling#301976pwang347 merged 2 commits intomicrosoft:mainfrom
pwang347 merged 2 commits intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes legacy support for the deprecated/misspelled user-invokable prompt header attribute (typo of user-invocable) across prompt parsing, validation, and attribute definitions, and updates tests to assert it is now treated as an unknown attribute.
Changes:
- Remove the
PromptHeaderAttributes.userInvokableconstant and parsing fallback inPromptHeader.userInvocable. - Remove deprecated attribute definitions and validator logic that previously warned about
user-invokable. - Update tests to validate
user-invocablebehavior and ensureuser-invokableis reported as unsupported/unknown.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/common/promptSyntax/promptFileParser.ts | Drops the user-invokable constant and removes the fallback when reading userInvocable. |
| src/vs/workbench/contrib/chat/common/promptSyntax/languageProviders/promptValidator.ts | Removes deprecated validation path and removes user-invokable from valid/recommended attribute sets so it becomes an unknown attribute. |
| src/vs/workbench/contrib/chat/common/promptSyntax/languageProviders/promptFileAttributes.ts | Removes deprecated user-invokable attribute definitions from agent/skill attribute registries and non-recommended checks. |
| src/vs/workbench/contrib/chat/test/common/promptSyntax/service/promptFileParser.test.ts | Updates parser tests to only assert user-invocable behavior (no deprecated fallback). |
| src/vs/workbench/contrib/chat/test/browser/promptSyntax/languageProviders/promptValidator.test.ts | Updates validator test to assert user-invokable now produces an “not supported” warning as an unknown attribute. |
pwang347
approved these changes
Mar 16, 2026
roblourens
approved these changes
Mar 16, 2026
xingsy97
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix TODO in file src/vs/workbench/contrib/chat/common/promptSyntax/promptFileParser.ts:"TODO: user-invokable is deprecated, remove later and only keep user-invocable"
The
user-invokableattribute (a typo ofuser-invocable) was deprecated and kept as a fallback. This removes all support for the misspelled variant:PromptHeaderAttributes.userInvokableconstantPromptHeader.userInvocablegettervalidateUserInvokablemethod and its call sitesallAttributeNamesandisNonRecommendedAttributeuser-invokableis now reported as an unknown attribute