Support terminal creation on web worker extension host when there's remote authority#300897
Merged
meganrogge merged 1 commit intomicrosoft:mainfrom Mar 12, 2026
Merged
Support terminal creation on web worker extension host when there's remote authority#300897meganrogge merged 1 commit intomicrosoft:mainfrom
meganrogge merged 1 commit intomicrosoft:mainfrom
Conversation
Contributor
Author
|
cc @meganrogge @Tyriar could you take a look 🙏 |
Contributor
There was a problem hiding this comment.
Pull request overview
Enables vscode.window.createTerminal* from the web worker extension host when running in a web context that has a remote authority (eg. VS Code Web connected to a remote), addressing the “Not supported” error in that scenario.
Changes:
- Injects
IExtHostInitDataServiceintoWorkerExtHostTerminalServiceto detect whether a remote authority exists. - Allows
createTerminal/createTerminalFromOptionsin the worker ext host only wheninitData.remote.authorityis present; otherwise continues throwingNotSupportedError.
You can also share your feedback on Copilot code review. Take the survey.
Contributor
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #300895