Repository navigation
Pzhu/feature custom snooze time - #298934
Merged
Benjamin Christopher Simmonds (benibenj) merged 5 commits intoMay 4, 2026
Merged
Benjamin Christopher Simmonds (benibenj) merged 5 commits into
Benjamin Christopher Simmonds (benibenj) merged 5 commits into
Conversation
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: Ladislau Szomoru (@lszomoru)Matched files:
|
Contributor
Author
|
I wrongly mixed two commits... I'll correct it a bit later. |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a “Custom” option to the inline suggestions snooze duration picker and updates the Chat Status Dashboard snooze UI to route initial snoozes through the command-based picker flow.
Changes:
- Add “Custom...” duration entry that prompts for a user-provided snooze duration (minutes, including fractional values).
- Update Chat Status Dashboard snooze button behavior: open the duration picker when starting snooze; keep “+5 min” extend behavior while already snoozing.
- Modify Git extension
git:filesystem provider behavior forref === '~'(diff-original) to try index first, then HEAD, and add related tests.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/chatStatus/chatStatusDashboard.ts | Adjusts snooze UI strings and changes click behavior to invoke the snooze picker command when not already snoozing. |
| src/vs/editor/browser/services/inlineCompletionsService.ts | Adds “Custom...” option and implements a quick input prompt to collect a custom snooze duration. |
| extensions/git/src/fileSystemProvider.ts | Adds fallback logic for ref === '~' in stat/readFile by probing index then HEAD. |
| extensions/git/src/test/git.test.ts | Adds tests intended to validate diff-original fallback behavior (currently via a local simulation helper). |
pzhu (Pengkun-ZHU)
marked this pull request as draft
March 3, 2026 11:49
pzhu (Pengkun-ZHU)
force-pushed
the
pzhu/feature-custom-snooze-time
branch
from
March 3, 2026 14:11
1025112 to
2a0d577
Compare
Contributor
Author
|
Removed the wrong commit. Kindly ignore the Copilot review on those removed files. |
pzhu (Pengkun-ZHU)
marked this pull request as ready for review
March 3, 2026 14:15
Benjamin Christopher Simmonds (benibenj)
requested changes
Mar 5, 2026
…on quick selection
Contributor
Author
|
A screen recording to demonstrate latest changes as of this comment: Screen.Recording.2026-03-06.at.00.15.08.mov |
pzhu (Pengkun-ZHU)
requested a review
from Benjamin Christopher Simmonds (benibenj)
March 5, 2026 16:19
Benjamin Christopher Simmonds (benibenj)
requested changes
Mar 11, 2026
Benjamin Christopher Simmonds (benibenj)
left a comment
Benjamin Christopher Simmonds (benibenj)
left a comment
Contributor
There was a problem hiding this comment.
Almost done, just 2 small things to undo
pzhu (Pengkun-ZHU)
requested a review
from Benjamin Christopher Simmonds (benibenj)
March 11, 2026 15:25
Benjamin Christopher Simmonds (benibenj)
enabled auto-merge (squash)
May 4, 2026 13:24
Benjamin Christopher Simmonds (benibenj)
approved these changes
May 4, 2026
Michael Lively (Yoyokrazy)
approved these changes
May 4, 2026
Benjamin Christopher Simmonds (benibenj)
merged commit May 4, 2026
4847e79
into
microsoft:main
39 of 41 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #288770
Feature
Add an option named "Custom" in the snooze quick pick.
How to test
Screen recording showing the fix works
Screen.Recording.2026-02-28.at.00.20.19.MOV
Screen.Recording.2026-03-03.at.01.22.40.MOV