rendering whitespace in overlay for lines with variable heights and fonts#298247
Merged
rendering whitespace in overlay for lines with variable heights and fonts#298247
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses VS Code issue #286150 by making whitespace rendering consistent when lines use font-affecting TextMate rules (variable fonts/line heights), ensuring the whitespace overlay is used instead of falling back to in-line whitespace rendering for some lines.
Changes:
- Stop suppressing
WhitespaceOverlayrendering on lines markedhasVariableFonts. - Remove the
hasVariableFonts-based fallback that forced in-line whitespace rendering inViewLinewhen experimental whitespace rendering is enabled.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/vs/editor/browser/viewParts/whitespace/whitespace.ts |
Allows the whitespace overlay to render on variable-font lines instead of skipping them. |
src/vs/editor/browser/viewParts/viewLines/viewLine.ts |
Ensures in-line whitespace rendering is only used when experimentalWhitespaceRendering === 'off', avoiding mixed rendering paths. |
deepak1556
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #286150