Skip to content

Fix code quality issues: error logging and JSDoc typo#297893

Merged
mjbvz merged 3 commits intomicrosoft:mainfrom
kbhujbal:fix/code-quality-improvements
Mar 20, 2026
Merged

Fix code quality issues: error logging and JSDoc typo#297893
mjbvz merged 3 commits intomicrosoft:mainfrom
kbhujbal:fix/code-quality-improvements

Conversation

@kbhujbal
Copy link
Copy Markdown
Contributor

  • Replace console.log(err) with console.error(err) in catch blocks in domLineBreaksComputer.ts and sharedWebContentExtractorService.ts
  • Remove redundant console.log that duplicates logService.info() in remote.ts
  • Fix JSDoc typo "Returns of" -> "Returns if" in offsetRange.ts

- Replace `console.log(err)` with `console.error(err)` in catch blocks
  in domLineBreaksComputer.ts and sharedWebContentExtractorService.ts
- Remove redundant `console.log` that duplicates `logService.info()` in
  remote.ts
- Fix JSDoc typo "Returns of" -> "Returns if" in offsetRange.ts

Co-Authored-By: Claude Opus 4.6 <[email protected]>
@kbhujbal
Copy link
Copy Markdown
Contributor Author

Fixes minor code quality issues across 4 files:

  • domLineBreaksComputer.ts: Replace console.log(err) with console.error(err) in catch block — errors should log at error level.
  • sharedWebContentExtractorService.ts: Same console.log(err)console.error(err) fix.
  • remote.ts: Remove redundant console.log() that duplicates the logService.info() call on the preceding line.
  • offsetRange.ts: Fix JSDoc typo "Returns of there is""Returns if there is".

No functional changes — only logging level corrections and a documentation fix.

Test plan

  • No functional code was modified
  • Error catch blocks now log at the correct severity level
  • JSDoc accurately describes the method behavior

@mjbvz mjbvz enabled auto-merge March 11, 2026 02:04
@vs-code-engineering vs-code-engineering bot added this to the 1.112.0 milestone Mar 11, 2026
@mjbvz mjbvz modified the milestones: 1.112.0, 1.113.0 Mar 16, 2026
@mjbvz mjbvz merged commit 5caa080 into microsoft:main Mar 20, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants