Skip to content

Fix history navigator to change the position when adding an existing element.#29763

Merged
sandy081 merged 2 commits intomicrosoft:masterfrom
stringham:fix-search-history
Jan 9, 2018
Merged

Fix history navigator to change the position when adding an existing element.#29763
sandy081 merged 2 commits intomicrosoft:masterfrom
stringham:fix-search-history

Conversation

@stringham
Copy link
Contributor

Fixes #29762

@stringham stringham force-pushed the fix-search-history branch from 588244c to 364760d Compare July 16, 2017 15:26
@stringham
Copy link
Contributor Author

@sandy081 I think this is a pretty straightforward fix. Is there anything holding it up?

@stringham stringham closed this Aug 29, 2017
@stringham stringham reopened this Aug 29, 2017
@sandy081 sandy081 added this to the September 2017 milestone Aug 29, 2017
@microsoft microsoft deleted a comment from msftclas Sep 27, 2017
@microsoft microsoft deleted a comment from msftclas Sep 27, 2017
@sandy081 sandy081 removed this from the September 2017 milestone Sep 27, 2017
@stringham
Copy link
Contributor Author

This was independently fixed by 3a69df3 two months after I submitted this patch.

It is difficult to contribute when pull requests are ignored. Especially very simple ones like this.

@stringham stringham closed this Jan 8, 2018
@sandy081
Copy link
Member

sandy081 commented Jan 9, 2018

@stringham Apologies for not getting this in. Missed my radar. I acknowledge your contribution. Thank you very much.

@sandy081 sandy081 reopened this Jan 9, 2018
@sandy081 sandy081 merged commit 9ff5abe into microsoft:master Jan 9, 2018
@sandy081 sandy081 added this to the December 2017/January 2018 milestone Jan 9, 2018
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression: History navigator does not re-order items when adding existing elements

4 participants