Open
Conversation
Fix spelling and grammar errors in comments only: - strings.ts: varinats -> variants - parcelWatcher.ts: occured -> occurred, coleasing -> coalescing, likelyhood -> likelihood - extHostTypes.ts: seperate -> separate - explorerViewer.ts: seperately -> separately, excpet -> except - commandDetectionCapability.ts: depended -> dependent
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @bpaseroMatched files:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description: Fix Marketplace Connection Issue (ERR_NO_SUPPORTED_PROXIES)
Description
This PR addresses an issue where VS Code fails to connect to the marketplace, reporting
ERR_NO_SUPPORTED_PROXIES.The root cause was identified in windowImpl.ts: when no proxy is configured, VS Code was calling Electron's
setProxywith an empty string forproxyRules. This caused Chromium to fail withERR_NO_SUPPORTED_PROXIESas it couldn't find any valid proxy configuration in the empty string.Changes
newHttpProxyis truthy before applying proxy rules.{}instead of an invalid empty string. This allows Electron to correctly fall back to system defaults.Verification
{}is the documented way to clear settings in Electron.