Don't re-render hovers if nothing has changed; Add telemetry on hovers#29387
Merged
alexdima merged 4 commits intomicrosoft:masterfrom Oct 24, 2017
Merged
Don't re-render hovers if nothing has changed; Add telemetry on hovers#29387alexdima merged 4 commits intomicrosoft:masterfrom
alexdima merged 4 commits intomicrosoft:masterfrom
Conversation
|
@dadlerj, thanks for your PR! By analyzing the history of the files in this pull request, we identified @alexandrudima and @egamma to be potential reviewers. |
Member
|
Thank you @dadlerj ❤️. I have removed the telemetry part from the PR and kept only the rendering part. Sorry for taking so long to merge this in! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #29388
The first commit adds the check for equality
The second commit adds telemetry for every hover
I'd be happy to kill the 2nd if you prefer it