Show installation progress in update status bar entry on Windows by dmitrivMS · Pull Request #292970 · microsoft/vscode

dmitrivMS · 2026-02-05T00:16:25Z

Copilot

Pull request overview

This PR adds installation progress reporting to the Windows update status bar entry. When VS Code is updating on Windows, users will now see a progress percentage in both the status bar text and tooltip, providing better visibility into the installation progress.

Changes:

Modified the Updating state type to include optional currentProgress and maxProgress fields for tracking installation progress
Updated the Windows update service to poll a progress file written by the Inno Setup installer and update the state with progress information
Enhanced the status bar UI to display progress percentage when available, with a visual progress bar in the tooltip
Modified the Inno Setup installer script to write progress information to a file during background updates

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File	Description
src/vs/platform/update/common/update.ts	Extended the `Updating` state type and factory function to include optional progress tracking fields
src/vs/platform/update/electron-main/updateService.win32.ts	Added polling logic to read progress from a file and update the state during installation
src/vs/workbench/contrib/update/browser/updateStatusBarEntry.ts	Enhanced UI to display progress percentage in status bar text and tooltip with a visual progress bar
build/win32/code.iss	Added Inno Setup callback to write installation progress to a file and cleanup logic for the progress file

Comments suppressed due to low confidence (3)

src/vs/platform/update/electron-main/updateService.win32.ts:348

The progress file created during installation is not cleaned up by the Node.js code when the update completes successfully via the ready mutex path or when the child process exits. While the Inno Setup installer does clean up the file in line 1642 of code.iss, if the installer crashes or is terminated abnormally, the progress file will remain in the cache directory.

Consider adding cleanup code to delete the progress file after the ready mutex is detected, or when the child process exits (in the 'exit' event handler at line 316).

		// poll for mutex-ready
		pollUntil(() => mutex.isActive(readyMutexName))
			.then(() => this.setState(State.Ready(update, explicit, this._overwrite)));
	}

src/vs/platform/update/electron-main/updateService.win32.ts:347

There's a potential race condition where both pollProgress and the existing pollUntil for the ready mutex could complete at similar times. When the ready mutex becomes active, the pollUntil will call setState(State.Ready(...)) at line 347, but the pollProgress loop at line 326 checks !mutex.isActive(readyMutexName) as its exit condition. If there's a timing issue, the polling loop could make one more setState call after the Ready state has been set, potentially updating the state unnecessarily or causing inconsistencies.

Consider adding a flag or ensuring the polling loop is properly cancelled when the ready state is reached.

		// Poll for progress and ready mutex
		const pollProgress = async () => {
			while (this.state.type === StateType.Updating && !mutex.isActive(readyMutexName)) {
				try {
					const progressContent = await readFile(progressFilePath, 'utf8');
					const [currentStr, maxStr] = progressContent.split(',');
					const currentProgress = parseInt(currentStr, 10);
					const maxProgress = parseInt(maxStr, 10);
					if (!isNaN(currentProgress) && !isNaN(maxProgress) && this.state.type === StateType.Updating) {
						this.setState(State.Updating(update, currentProgress, maxProgress));
					}
				} catch {
					// Progress file may not exist yet or be locked, ignore
				}
				await timeout(500);
			}
		};

		// Start polling for progress
		pollProgress();

		// poll for mutex-ready
		pollUntil(() => mutex.isActive(readyMutexName))
			.then(() => this.setState(State.Ready(update, explicit, this._overwrite)));

src/vs/workbench/contrib/update/browser/updateStatusBarEntry.ts:330

The percentage calculation doesn't bound the result to a maximum of 100%. If currentProgress exceeds maxProgress (which could happen due to timing issues or installer bugs), the percentage could exceed 100%, potentially causing the progress bar to overflow its container or display misleading information like "105%".

Consider capping the percentage at 100% using Math.min(Math.round((currentProgress / maxProgress) * 100), 100) to handle edge cases gracefully.

					const percentage = Math.round((currentProgress / maxProgress) * 100);

					const progressContainer = dom.append(container, dom.$('.progress-container'));
					const progressBar = dom.append(progressContainer, dom.$('.progress-bar'));
					const progressFill = dom.append(progressBar, dom.$('.progress-fill'));
					progressFill.style.width = `${percentage}%`;

src/vs/workbench/contrib/update/browser/updateStatusBarEntry.ts

build/win32/code.iss

src/vs/platform/update/electron-main/updateService.win32.ts

…ogress-win32

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

Comments suppressed due to low confidence (2)

src/vs/platform/update/electron-main/updateService.win32.ts:365

pollProgress() is started without awaiting/handling rejection. If anything throws outside the inner try/catch (e.g. mutex access), this can become an unhandled promise rejection. Consider invoking it with void … and attaching a .catch(...) (or wrapping the loop body in a top-level try/catch) to ensure failures are contained/logged.

		// Poll for progress and ready mutex
		const pollProgress = async () => {
			while (this.state.type === StateType.Updating && !mutex.isActive(readyMutexName)) {
				try {
					const progressContent = await readFile(progressFilePath, 'utf8');
					const [currentStr, maxStr] = progressContent.split(',');
					const currentProgress = parseInt(currentStr, 10);
					const maxProgress = parseInt(maxStr, 10);
					if (!isNaN(currentProgress) && !isNaN(maxProgress) && this.state.type === StateType.Updating) {
						this.setState(State.Updating(update, currentProgress, maxProgress));
					}
				} catch {
					// Progress file may not exist yet or be locked, ignore
				}
				await timeout(500);
			}
		};

		// Start polling for progress
		pollProgress();

src/vs/platform/update/electron-main/updateService.win32.ts:359

The progress polling loop calls setState(State.Updating(...)) every 500ms even if the parsed values haven’t changed, which will fire onStateChange and log update#setState repeatedly. Consider comparing against the current state’s currentProgress/maxProgress and only calling setState when the values actually change.

					const progressContent = await readFile(progressFilePath, 'utf8');
					const [currentStr, maxStr] = progressContent.split(',');
					const currentProgress = parseInt(currentStr, 10);
					const maxProgress = parseInt(maxStr, 10);
					if (!isNaN(currentProgress) && !isNaN(maxProgress) && this.state.type === StateType.Updating) {
						this.setState(State.Updating(update, currentProgress, maxProgress));
					}
				} catch {
					// Progress file may not exist yet or be locked, ignore
				}
				await timeout(500);

src/vs/platform/update/electron-main/updateService.win32.ts

build/win32/code.iss

src/vs/workbench/contrib/update/browser/updateStatusBarEntry.ts

src/vs/platform/update/electron-main/updateService.win32.ts

…ogress-win32

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

build/win32/code.iss

src/vs/workbench/contrib/update/browser/updateStatusBarEntry.ts

src/vs/platform/update/electron-main/updateService.win32.ts

…ogress-win32

src/vs/platform/update/electron-main/updateService.win32.ts

deepak1556

LGTM with nit

Show installation progress in update status bar entry on Windows

b8e51bd

dmitrivMS requested review from Copilot, deepak1556 and joaomoreno February 5, 2026 00:16

dmitrivMS self-assigned this Feb 5, 2026

dmitrivMS added this to the February 2026 milestone Feb 5, 2026

Copilot started reviewing on behalf of dmitrivMS February 5, 2026 00:16 View session

dmitrivMS added install-update VS Code installation and upgrade system issues windows VS Code on Windows issues labels Feb 5, 2026

Copilot AI reviewed Feb 5, 2026

View reviewed changes

dmitrivMS added 2 commits February 9, 2026 01:30

Merge remote-tracking branch 'origin/main' into dev/dmitriv/update-pr…

2e08de3

…ogress-win32

Updates, PR feedback

049b1f9

dmitrivMS requested a review from Copilot February 9, 2026 10:04

Copilot started reviewing on behalf of dmitrivMS February 9, 2026 10:04 View session

Copilot AI reviewed Feb 9, 2026

View reviewed changes

dmitrivMS added 4 commits February 9, 2026 04:22

Update progress file path.

73d0ace

Cleanup

e606215

Add unit-tests

6ad9c30

Merge branch 'main' into dev/dmitriv/update-progress-win32

626c255

dmitrivMS marked this pull request as ready for review February 9, 2026 13:21

dmitrivMS enabled auto-merge (squash) February 9, 2026 13:23

dmitrivMS added 5 commits February 9, 2026 07:07

Merge branch 'main' into dev/dmitriv/update-progress-win32

0c6c8ac

Merge branch 'main' into dev/dmitriv/update-progress-win32

b1cd2e6

Merge branch 'main' into dev/dmitriv/update-progress-win32

3713c33

Merge remote-tracking branch 'origin/main' into dev/dmitriv/update-pr…

e8ed46b

…ogress-win32

Updates

dff000c

dmitrivMS disabled auto-merge February 10, 2026 12:48

Add cancellation support to update polling loop

479047e

dmitrivMS requested a review from Copilot February 10, 2026 12:59

Copilot started reviewing on behalf of dmitrivMS February 10, 2026 12:59 View session

Copilot AI reviewed Feb 10, 2026

View reviewed changes

dmitrivMS added 5 commits February 10, 2026 15:57

Merge branch 'main' into dev/dmitriv/update-progress-win32

3b2f583

Merge remote-tracking branch 'origin/main' into dev/dmitriv/update-pr…

d41a580

…ogress-win32

Merge remote-tracking branch 'origin/main' into dev/dmitriv/update-pr…

d7c30e1

…ogress-win32

PR feedback

cd546f7

Add another check for cancellation

9a0d737

deepak1556 reviewed Feb 12, 2026

View reviewed changes

src/vs/platform/update/electron-main/updateService.win32.ts Show resolved Hide resolved

deepak1556 approved these changes Feb 12, 2026

View reviewed changes

dmitrivMS merged commit e44773c into main Feb 12, 2026
40 of 41 checks passed

dmitrivMS deleted the dev/dmitriv/update-progress-win32 branch February 12, 2026 11:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Show installation progress in update status bar entry on Windows#292970

Show installation progress in update status bar entry on Windows#292970
dmitrivMS merged 18 commits intomainfrom
dev/dmitriv/update-progress-win32

dmitrivMS commented Feb 5, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

deepak1556 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

dmitrivMS commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

deepak1556 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dmitrivMS commented Feb 5, 2026 •

edited

Loading