font annotations: make delete annotations work with intersecting annotations#292815
Merged
font annotations: make delete annotations work with intersecting annotations#292815
Conversation
aiday-mar
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where font token customization settings weren't being properly cleaned up when changed, causing certain lines to be incorrectly centered. The fix modifies the annotation intersection logic to properly handle deletion of annotations at boundary positions.
Changes:
- Modified intersection logic in
_getEndIndexOfIntersectingAnnotationto include annotations that start exactly at the query range's end position - Added a new test case demonstrating deletion of an annotation using an empty range at its start position
- Updated two existing test cases to reflect the new intersection semantics
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/editor/common/model/tokens/annotations.ts | Changed boundary condition from > to >= to properly detect annotations starting at the query offset |
| src/vs/editor/test/common/model/annotations.test.ts | Added test for empty-range annotation deletion and updated existing intersection tests to match new semantics |
bpasero
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #292286