fix: making the line height multiplier at least as big as the font size multiplier#289364
Merged
fix: making the line height multiplier at least as big as the font size multiplier#289364
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where the line height could be smaller than the font size in token color customizations, which would cause rendering problems. The fix ensures that whenever a fontSize is specified in textMate rules, the lineHeight is automatically adjusted to be at least as large as the fontSize.
Changes:
- Modified
tokenColorCustomizationsgetter to enforce minimum lineHeight equal to fontSize for all textMateRules
alexdima
approved these changes
Jan 22, 2026
Member
alexdima
left a comment
alexdima
left a comment
There was a problem hiding this comment.
Nice! I made a small tweak to compute it only when it is not explicitly set
DonJayamanne
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #288844