adding the line height into the model decorations returned by font token decorations provider#289099
Merged
adding the line height into the model decorations returned by font token decorations provider#289099
Conversation
…ken decorations provider
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where font token decorations' line height values weren't being properly set. The PR updates the lineHeight property to use a multiplier of the default line height instead of an absolute pixel value, aligning with how line height multipliers are already used elsewhere in the codebase.
Changes:
- Updated documentation in
model.tsandmonaco.d.tsto clarify thatlineHeightis a multiplier to the default line height - Modified
viewModelImpl.tsto multiply the decoration's line height by the default line height when computing custom line heights - Added
lineHeightproperty to font token decorations intokenizationFontDecorationsProvider.ts
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/monaco.d.ts | Updated comment to clarify lineHeight is a multiplier rather than absolute pixel value |
| src/vs/editor/common/model.ts | Updated comment to match monaco.d.ts documentation |
| src/vs/editor/common/viewModel/viewModelImpl.ts | Added logic to multiply lineHeight by defaultLineHeight when computing custom line heights |
| src/vs/editor/common/model/tokens/tokenizationFontDecorationsProvider.ts | Added lineHeight property from fontToken to decoration options |
bpasero
approved these changes
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #288847