making the getViewportViewLineRenderingData return the correct hasFontInfo#289083
Merged
making the getViewportViewLineRenderingData return the correct hasFontInfo#289083
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #286150 by making hasVariableFonts track font-affecting decorations on a per-line basis instead of globally across the viewport. Previously, if any line in the viewport had a decoration that affected fonts, all lines would be treated as having variable fonts, which could lead to incorrect rendering behavior.
Changes:
- Changed
hasVariableFontsfrom a single boolean to an array of booleans (one per line in the range) - Updated the decoration collection logic to track font-affecting decorations per line
- Updated consumers to access the per-line boolean values from the array
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/editor/common/viewModel/viewModelDecorations.ts | Changed hasVariableFonts from boolean to boolean[] in interface; updated _getDecorationsInRange to initialize and populate per-line boolean array |
| src/vs/editor/common/viewModel/viewModelImpl.ts | Updated getViewportViewLineRenderingData and getViewLineRenderingData to access per-line hasVariableFonts values from the array |
benibenj
approved these changes
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #286150