sending the font token decorations in the custom line heights too#288941
Merged
sending the font token decorations in the custom line heights too#288941
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where font token decorations with custom line heights were not being included when retrieving custom line height decorations.
Changes:
- Fixed
getAllDecorations()inTokenizationFontDecorationProviderto include the full last line instead of just column 1 - Updated
getCustomLineHeightsDecorations()inTextModelto include font token decorations alongside decorations tree results
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/vs/editor/common/model/tokens/tokenizationFontDecorationsProvider.ts |
Extended the range in getAllDecorations() to include the complete last line by using getLineMaxColumn() instead of column 1 |
src/vs/editor/common/model/textModel.ts |
Added font token decorations to the result of getCustomLineHeightsDecorations() using pushMany(), consistent with how other decoration retrieval methods combine multiple decoration sources |
Tyriar
approved these changes
Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #288847