Skip to content

fix terminal suggest regression #287610

Merged
meganrogge merged 1 commit intorelease/1.108from
merogge/sibling
Jan 13, 2026
Merged

fix terminal suggest regression #287610
meganrogge merged 1 commit intorelease/1.108from
merogge/sibling

Conversation

@meganrogge
Copy link
Collaborator

fixes #287161

The bug was caused by double-navigation when typing ../:

  • Extension side: resolveCwdFromCurrentCommandString() was pre-resolving ../ paths, setting cwd to the parent directory
  • Completion service side: When processing ../, it did URI.joinPath(cwd, '../') which navigated up AGAIN from the already-resolved parent

So typing ../ from vscode resulted in:

  • Extension resolved cwd to Repos (parent)
  • Completion service then did joinPath(parent, '../') = meganrogge(grandparent)
  • Children shown were from grandparent, showing Repos instead of xterm.js

Added a check in resolveCwdFromCurrentCommandString to skip pre-resolution for paths containing .. to fix this.

@meganrogge meganrogge self-assigned this Jan 13, 2026
@meganrogge meganrogge added this to the December 2025 Recovery 1 milestone Jan 13, 2026
@meganrogge meganrogge enabled auto-merge (squash) January 13, 2026 19:01
@meganrogge meganrogge merged commit 585eba7 into release/1.108 Jan 13, 2026
22 checks passed
@meganrogge meganrogge deleted the merogge/sibling branch January 13, 2026 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants