Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates xterm.js and its addons from version 6.1.0-beta.91 to 6.1.0-beta.99, and adds support for the kitty keyboard protocol. The kitty keyboard protocol is an experimental feature that provides more detailed keyboard input reporting to the terminal.
Changes:
- Updated xterm.js core and all related addons to beta.99 (webgl addon to beta.98)
- Added new experimental setting
terminal.integrated.enableKittyKeyboardProtocol(defaults to false) - Wired the kitty keyboard protocol configuration through to xterm.js via
vtExtensions.kittyKeyboard
Reviewed changes
Copilot reviewed 7 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/terminal/common/terminalConfiguration.ts | Added missing trailing comma and new kitty keyboard protocol configuration setting |
| src/vs/workbench/contrib/terminal/common/terminal.ts | Added enableKittyKeyboardProtocol property to ITerminalConfiguration interface |
| src/vs/workbench/contrib/terminal/browser/xterm/xtermTerminal.ts | Wired kitty keyboard protocol config to xterm in initialization and updateConfig |
| src/vs/platform/terminal/common/terminal.ts | Added EnableKittyKeyboardProtocol setting ID to enum |
| package.json, remote/package.json, remote/web/package.json | Updated xterm package versions |
| package-lock.json, remote/package-lock.json, remote/web/package-lock.json | Updated lockfiles to match package version changes |
Files not reviewed (2)
- remote/package-lock.json: Language not supported
- remote/web/package-lock.json: Language not supported
These are no longer needed with win32-input-mode
dmitrivMS
approved these changes
Jan 10, 2026
eli-w-king
pushed a commit
that referenced
this pull request
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #286809
Fixes #286810
Fixes #286896