Finalize quickInputbuttonLocation API#286388
Merged
Conversation
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @lszomoruMatched files:
|
Contributor
Author
|
Per @TylerLeonhardt this is targeting Jan now. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR finalizes the quickInputButtonLocation API by promoting it from proposed to stable status. The changes move the API definitions from the proposed file into the main vscode.d.ts type definitions file and remove all proposal gates and references.
Key Changes
- Moved
QuickInputButtonLocationenum and related button properties from proposed API to stable API in vscode.d.ts - Removed the proposal check that gated access to
locationandtoggleproperties in extHostQuickOpen.ts - Removed the
quickInputButtonLocationentry from the API proposals registry
Reviewed changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/vscode-dts/vscode.proposed.quickInputButtonLocation.d.ts | Deleted the proposed API definition file as the API is now stable |
| src/vscode-dts/vscode.d.ts | Added QuickInputButtonLocation enum and location/toggle properties to QuickInputButton interface |
| src/vs/workbench/api/common/extHostQuickOpen.ts | Removed proposal check for location and toggle properties when setting buttons |
| src/vs/platform/extensions/common/extensionsApiProposals.ts | Removed quickInputButtonLocation from the proposals registry |
| extensions/vscode-api-tests/package.json | Removed quickInputButtonLocation from enabled proposals for API tests |
| extensions/git/tsconfig.json | Removed reference to proposed API file from TypeScript configuration |
| extensions/git/package.json | Removed quickInputButtonLocation from git extension's enabled proposals |
mjbvz
approved these changes
Jan 7, 2026
dmitrivMS
deleted the
dev/dmitriv/finalize-quickInputButtonLocation-api
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #144956
Fixes #221397