Pull request overview

This pull request converts font size and line height values from absolute (string-based) to relative (number multiplier-based) values for token colorization settings. This allows theme authors to specify font sizes and line heights as multipliers of the editor's default font settings rather than hardcoded pixel values.

Key Changes:

• Changed fontSize type from string to number across theme interfaces, representing a multiplier instead of an absolute value
• Renamed properties to fontSizeMultiplier and lineHeightMultiplier in internal interfaces to clarify their purpose
• Added new event type ModelLineHeightMultiplierChangedEvent to handle multiplier-based line height changes
• Updated CSS generation to multiply multipliers by the configured editor font size

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 11 comments.

I've left comments, mostly OK, except I would try to make it that everyone who adds line height decorations can only do relative line heights, no more absolutes to keep the code sane.

Also, when generating the CSS and the class name inside the text model it looks like the font size is being read, it would be better to avoid it and use the relative multiplier in the class name to remove that dependency on the config service (and avoid the bug of not reacting to the value changing)

Nice!

I just found a problem and pushed a fix where configuring:

"editor.tokenColorCustomizations": {
        "textMateRules": [{
            "scope": "entity.name.type.class.ts",
            "settings": {
                "foreground": "#FF0000",
                "fontStyle": "bold",
                "lineHeight": 1.5,
                "fontSize": 1.5
            }
        }]
    },

would generate a class name .font-decoration-default-1.5 which wouldn't work due to the . in the font size.