Tighten webgl lifecycle, ensure chat doesn't use#285579
Merged
Conversation
The webgl renderer has a limited number of contexts, because there are potentially many chat terminals and interaction with them is minimal, we don't want to consume one of the contexts. Fixes #285452
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens WebGL renderer lifecycle management to prevent WebGL context leaks and ensures chat terminals don't consume limited WebGL contexts.
- Adds explicit disposal of existing WebGL addons before creating new ones to avoid context leaks
- Converts sticky scroll WebGL addon management to use MutableDisposable for better lifecycle control
- Disables GPU acceleration for chat terminals to conserve the limited number of available WebGL contexts
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/terminalContrib/stickyScroll/browser/terminalStickyScrollOverlay.ts | Converts _webglAddon from optional property to MutableDisposable for automatic cleanup and adds disposal comment |
| src/vs/workbench/contrib/terminal/browser/xterm/xtermTerminal.ts | Adds explicit _disposeOfWebglRenderer() call before creating new WebGL addon and adds guard clause to disposal method |
| src/vs/workbench/contrib/terminal/browser/chatTerminalCommandMirror.ts | Passes enableGpu: false option when attaching chat terminals to prevent WebGL context consumption |
dmitrivMS
approved these changes
Jan 2, 2026
Collaborator
|
Thanks for fixing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The webgl renderer has a limited number of contexts, because there are potentially many chat terminals and interaction with them is minimal, we don't want to consume one of the contexts.
Fixes #285452