Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates xterm and related addons from version 6.1.0-beta.22 to 6.1.0-beta.56, fixing several terminal-related issues. The update includes changes to package dependencies, removal of a conflicting keybinding, and an adjustment to the xterm update script.
- Updates xterm core library and most addons from beta.22 to beta.56
- Updates webgl addon from beta.21 to beta.55
- Removes ctrl+/ keybinding that was conflicting with VS Code's toggle comment functionality
- Modifies the xterm-update script validation to be more flexible with directory names
Reviewed changes
Copilot reviewed 5 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/terminalContrib/sendSequence/browser/terminal.sendSequence.contribution.ts | Removes ctrl+/ keybinding registration to resolve keybinding conflicts |
| scripts/xterm-update.js | Updates directory validation from exact "vscode" match to regex pattern allowing "vscode" anywhere in basename |
| remote/web/package.json | Updates xterm dependencies to beta.56 (beta.55 for webgl) |
| remote/web/package-lock.json | Updates resolved package versions and integrity hashes for xterm dependencies |
| remote/package.json | Updates xterm dependencies to beta.56 (beta.55 for webgl), adds headless package |
| remote/package-lock.json | Updates resolved package versions and integrity hashes for xterm dependencies |
| package.json | Updates xterm dependencies to beta.56 (beta.55 for webgl) in root package |
| package-lock.json | Updates resolved package versions and integrity hashes for xterm dependencies in root lockfile |
Files not reviewed (2)
- remote/package-lock.json: Language not supported
- remote/web/package-lock.json: Language not supported
| const vscodeDir = process.argv.length >= 3 ? process.argv[2] : process.cwd(); | ||
| if (path.basename(vscodeDir) !== 'vscode') { | ||
| console.error('The cwd is not named "vscode"'); | ||
| if (!path.basename(vscodeDir).match(/.*vscode.*/)) { |
There was a problem hiding this comment.
The regex pattern .*vscode.* will match any path containing "vscode" anywhere in the basename, including cases like "vscode-backup", "my-vscode-fork", or even "not-vscode-at-all". This makes the validation too permissive. Consider using a more specific pattern like /^vscode(-[a-z]+)?$/ to match "vscode" exactly or with specific suffixes like "vscode-insiders".
| if (!path.basename(vscodeDir).match(/.*vscode.*/)) { | |
| if (!path.basename(vscodeDir).match(/^vscode(-[a-z]+)?$/)) { |
Fixes #285138
Fixes #285180
Fixes #252449
Fixes #230120