Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR upgrades xterm and its related addons from version 5.6.0-beta.136 to 6.1.0-beta.22, addressing two reported issues (#284592 and #284758). The update involves a major version bump from xterm 5.x to 6.x and includes improved documentation for the custom glyphs feature.
Key Changes
- Upgraded xterm core library from 5.6.0-beta.136 to 6.1.0-beta.22 (major version bump)
- Updated all xterm addons to their corresponding beta.22 versions (with addon-webgl at beta.21)
- Enhanced terminal.integrated.customGlyphs documentation with detailed Unicode range information
Reviewed changes
Copilot reviewed 4 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/terminal/common/terminalConfiguration.ts | Expanded documentation for customGlyphs setting to list specific Unicode ranges covered by the feature |
| remote/web/package.json | Updated xterm and addon dependencies to beta.22 versions for web remote scenario |
| remote/web/package-lock.json | Lockfile updates reflecting the new xterm package versions and integrity hashes |
| remote/package.json | Updated xterm and addon dependencies including the headless addon for remote scenarios |
| remote/package-lock.json | Lockfile updates with new versions, integrity hashes, and workspace configuration |
| package.json | Root package.json updates for all xterm dependencies to beta.22 versions |
| package-lock.json | Comprehensive lockfile updates with version changes and new workspace metadata |
Files not reviewed (2)
- remote/package-lock.json: Language not supported
- remote/web/package-lock.json: Language not supported
src/vs/workbench/contrib/terminal/common/terminalConfiguration.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
lszomoru
previously approved these changes
Dec 25, 2025
Member
|
@Tyriar, PR check is 🔴 |
lszomoru
approved these changes
Dec 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #284592
Fixes #284758
FYI @chrislloyd