Make onEnterRules patterns case-insensitive for Visual Basic#284782
Closed
Copilot wants to merge 3 commits intodev/dmitriv/vb-indent-rulesfrom
Closed
Make onEnterRules patterns case-insensitive for Visual Basic#284782Copilot wants to merge 3 commits intodev/dmitriv/vb-indent-rulesfrom
Copilot wants to merge 3 commits intodev/dmitriv/vb-indent-rulesfrom
Conversation
Co-authored-by: dmitrivMS <[email protected]>
Copilot
AI
changed the title
[WIP] Update indentation rules for Visual Basic based on feedback
Make onEnterRules patterns case-insensitive for Visual Basic
Dec 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Visual Basic is case-insensitive, but the
onEnterRulespatterns inlanguage-configuration.jsonwere matching keywords case-sensitively. This meant indentation behavior would fail for code written as "end if" or "END IF" instead of "End If".Changes
onEnterRulespatterns from string format to object format with"flags": "i"beforeTextpattern in first rule (End statements and block terminators)previousLineTextpattern in second rule (blank line after block terminators)beforeTextpattern in third rule (lines ending with closing parenthesis)This aligns with patterns used in HTML and Handlebars language configurations for case-insensitive languages.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.