Add indentation rules for Visual Basic#284711
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds indentation rules for Visual Basic to fix issue #118932, enabling automatic indentation support for VB files. The changes introduce regex patterns that match VB block structures (If/End If, Sub/End Sub, etc.) to determine when to increase or decrease indentation.
Key Changes
- Added
vbIndentationRuleswith patterns for Visual Basic block structures - Enabled and updated test case to verify indentation behavior
- Added comprehensive onEnterRules for proper line break handling
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/vs/editor/test/common/modes/supports/indentationRules.ts | Exports test indentation rules with case-insensitive VB keyword patterns |
| src/vs/editor/contrib/indentation/test/browser/indentation.test.ts | Imports and registers VB rules, enables previously skipped test |
| extensions/vb/language-configuration.json | Adds indentation and onEnter rules for production use, but patterns lack case-insensitive flags |
Contributor
|
@dmitrivMS I've opened a new pull request, #284782, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: Copilot <[email protected]>
Co-authored-by: dmitrivMS <[email protected]>
…dmitriv/vb-indent-rules
aiday-mar
approved these changes
Dec 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #118932