Finalize quickPickItemResource API proposal#283877
Merged
Conversation
mjbvz
approved these changes
Dec 16, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR finalizes the quickPickItemResource API proposal by promoting it from proposed to stable API. The resourceUri property is now available on the QuickPickItem interface without requiring extensions to opt-in to proposed APIs. This property enables automatic derivation of labels, descriptions, and icons from file URIs.
Key changes:
- Moved
resourceUriproperty from proposed API to stableQuickPickIteminterface in vscode.d.ts - Removed the proposed API definition file
- Removed all proposal guards that previously gated access to this API
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/vscode-dts/vscode.proposed.quickPickItemResource.d.ts | Deleted the proposed API definition file as the API is now stable |
| src/vscode-dts/vscode.d.ts | Added resourceUri property to the stable QuickPickItem interface with complete documentation |
| src/vs/workbench/api/common/extHostQuickOpen.ts | Removed checkProposedApiEnabled guards for resourceUri in two locations (showQuickPick and QuickPick setter) |
| src/vs/platform/extensions/common/extensionsApiProposals.ts | Removed the quickPickItemResource entry from the API proposals registry |
| extensions/vscode-api-tests/package.json | Removed quickPickItemResource from the test extension's enabled API proposals list |
The changes are complete and correct. All necessary steps for finalizing a proposed API have been properly executed, and the implementation and tests already support the finalized API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #59826