Skip to content

Finalize quickPickPrompt API#283874

Merged
dmitrivMS merged 1 commit intomainfrom
dev/dmitriv/finalize-prompt-api
Dec 16, 2025
Merged

Finalize quickPickPrompt API#283874
dmitrivMS merged 1 commit intomainfrom
dev/dmitriv/finalize-prompt-api

Conversation

@dmitrivMS
Copy link
Contributor

Fixes #78335

Copilot AI review requested due to automatic review settings December 16, 2025 18:24
@dmitrivMS dmitrivMS added quick-pick Quick-pick widget issues api-finalization labels Dec 16, 2025
@dmitrivMS dmitrivMS self-assigned this Dec 16, 2025
@dmitrivMS dmitrivMS enabled auto-merge (squash) December 16, 2025 18:24
@vs-code-engineering vs-code-engineering bot added this to the December / January 2026 milestone Dec 16, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR finalizes the quickPickPrompt API (issue #78335) by promoting it from proposed to stable status. The prompt property allows extension authors to provide additional instructions or context text that appears below the input box and above the list of items in quick pick UIs.

Key changes:

  • Moved prompt property from proposed API to stable API in both QuickPickOptions and QuickPick interfaces
  • Removed all proposal gating checks that previously restricted API usage
  • Deleted the proposal definition file and registry entry

Reviewed changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.

File Description
src/vscode-dts/vscode.proposed.quickPickPrompt.d.ts Deleted the proposed API definition file as the API is now stable
src/vscode-dts/vscode.d.ts Added prompt property to QuickPickOptions (line 2008) and QuickPick interface (line 13139) with consistent documentation
src/vs/workbench/api/common/extHostQuickOpen.ts Removed checkProposedApiEnabled calls for quickPickPrompt from both showQuickPick method and QuickPick.prompt setter
src/vs/platform/extensions/common/extensionsApiProposals.ts Removed quickPickPrompt entry from the API proposals registry

@dmitrivMS dmitrivMS merged commit 1d9de1a into main Dec 16, 2025
33 of 34 checks passed
@dmitrivMS dmitrivMS deleted the dev/dmitriv/finalize-prompt-api branch December 16, 2025 19:11
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Jan 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api-finalization quick-pick Quick-pick widget issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support prompt for QuickPick as well as InputBox

3 participants