Revert "Fixed wrong negation in the _shouldRenderHint logic. (#242479)"#282913
Merged
DonJayamanne merged 1 commit intomainfrom Dec 12, 2025
Merged
Revert "Fixed wrong negation in the _shouldRenderHint logic. (#242479)"#282913DonJayamanne merged 1 commit intomainfrom
DonJayamanne merged 1 commit intomainfrom
Conversation
This reverts commit 5dab780.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts a previous commit (5dab780) that attempted to fix a negation issue in the shouldRenderHint logic. However, this revert reintroduces the original bug by checking !activeEditor.isDisposed instead of activeEditor.isDisposed.
Key Changes
- Reverts the conditional check from
activeEditor.isDisposedback to!activeEditor.isDisposedin theshouldRenderHintmethod
src/vs/workbench/contrib/notebook/browser/contrib/editorHint/emptyCellEditorHint.ts
Show resolved
Hide resolved
dmitrivMS
approved these changes
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 5dab780.
Fixes #282615