Fix: use codicon id for Command Prompt default profile icon#280967
Merged
Tyriar merged 4 commits intomicrosoft:mainfrom Dec 19, 2025
Merged
Fix: use codicon id for Command Prompt default profile icon#280967Tyriar merged 4 commits intomicrosoft:mainfrom
Tyriar merged 4 commits intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR corrects an inconsistency in the Windows terminal default profiles configuration where the Command Prompt profile used the Codicon object directly instead of its ID string. This ensures proper serialization and display in the settings UI.
- Changed
icon: Codicon.terminalCmdtoicon: Codicon.terminalCmd.idfor the Command Prompt profile
aiday-mar
requested review from
Tyriar and
anthonykim1
and removed request for
Tyriar
Tyriar
approved these changes
Dec 15, 2025
Member
|
@sudip-kumar-prasad please stop merging, it resets CI and I need to manually restart it every time. |
bpasero
approved these changes
Dec 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a small but important inconsistency in the terminal default profiles schema for Windows.
Problem
The default profile for "Command Prompt" used
icon: Codicon.terminalCmd(the codicon object), while schema and other defaults use the codicon ID (a string), e.g.Codicon.terminalPowershell.id. Using the object can cause incorrect serialization/display of the icon in settings UI.Fix
Change the
iconvalue to use the codicon id string:icon: Codicon.terminalCmd->icon: Codicon.terminalCmd.idWhy this is safe
Thanks!