Skip to content

fix: memory leak in markdown hover#280745

Merged
mjbvz merged 2 commits intomicrosoft:mainfrom
SimonSiefke:fix/memory-leak-markdown-hover
Dec 8, 2025
Merged

fix: memory leak in markdown hover#280745
mjbvz merged 2 commits intomicrosoft:mainfrom
SimonSiefke:fix/memory-leak-markdown-hover

Conversation

@SimonSiefke
Copy link
Contributor

Registering the WorkbenchHoverDelegate disposable.

Before

When calling the chat editor attach all problems and clearing chat context 197 times, the number of WorkbenchHoverDelegate functions grows by 1 each time.

before

After

No more leak is detected

@mjbvz mjbvz added this to the December / January 2026 milestone Dec 2, 2025
@mjbvz
Copy link
Collaborator

mjbvz commented Dec 3, 2025

Thanks! We are current testing and finalizing the upcoming release so I will merge this early next week for our January release

@mjbvz mjbvz enabled auto-merge December 8, 2025 21:22
@mjbvz mjbvz merged commit f105ad9 into microsoft:main Dec 8, 2025
18 checks passed
@SimonSiefke SimonSiefke deleted the fix/memory-leak-markdown-hover branch January 15, 2026 15:08
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Jan 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants