fix: memory leak in composite bar#280659
Merged
benibenj merged 7 commits intomicrosoft:mainfrom Dec 4, 2025
Merged
Conversation
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @bpaseroMatched files:
|
Contributor
|
Thank you very much for looking into this and creating a PR! I think mutable disposables would be very handy in this case. I created a PR against your branch, hope you are fine with that approach. SimonSiefke#60 |
lszomoru
approved these changes
Dec 4, 2025
sandy081
approved these changes
Dec 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a memory leak in composite bar.
A bit simplified the function looks like this:
Since the
updateCompositeSwitchercan run many times, it can callthis._registermany times, registering thecompositeOverflowActionand thecompositeOverflowActionViewItemdisposables tothis._storeeach time.Change
The change is making sure to remove
compositeOverflowActionandcompositeOverflowActionViewItemfromthis._storewhen disposing it and setting it to undefined.Before
When creating and closing a terminal 197 times, the number of functions related to CompositeOverflowActivityItem grows by one each time:
After
No more memory leak related to composite bar is detected:
