feat: add setting to control throttling for chat sessions#280591
Merged
deepak1556 merged 2 commits intomainfrom Dec 2, 2025
Merged
feat: add setting to control throttling for chat sessions#280591deepak1556 merged 2 commits intomainfrom
deepak1556 merged 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new configuration setting chat.suspendThrottling to control whether background throttling is suspended during chat requests. The feature is being introduced as a diagnostic tool to investigate issue #263554 where background throttling changes may be affecting compositing behavior.
Key changes:
- New configuration enum value
SuspendThrottlingadded toChatConfiguration - Configuration setting registered with default value
trueto maintain current behavior - Handler implementation updated to check the setting before suspending throttling
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/vs/workbench/contrib/chat/common/constants.ts |
Added SuspendThrottling enum value to ChatConfiguration |
src/vs/workbench/contrib/chat/browser/chat.contribution.ts |
Registered the new boolean configuration setting with localized description |
src/vs/workbench/contrib/chat/electron-browser/chat.contribution.ts |
Updated ChatSuspendThrottlingHandler to respect the new setting, added IConfigurationService dependency, and consolidated imports |
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
src/vs/workbench/contrib/chat/electron-browser/chat.contribution.ts
Outdated
Show resolved
Hide resolved
chrmarti
previously approved these changes
Dec 2, 2025
deepak1556
force-pushed
the
robo/chat_throttling_setting
branch
from
60e760b to
5632640
Compare
bpasero
requested changes
Dec 2, 2025
bpasero
approved these changes
Dec 2, 2025
deepak1556
added a commit
that referenced
this pull request
Jan 16, 2026
* fix: disable skia graphite backend Refs https://gist.github.com/deepak1556/434964e5e379339be1d02db2a9afb743 * chore: rm enable-graphite-invalid-recording-recovery switch * Revert "feat: add setting to control throttling for chat sessions (#280591)" This reverts commit 5efc1d0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #263554
Based on some trace logs from @chrmarti who is occasionally affected by this issue, we are changing the background throttling of the affected windows but I am not sure why that would break compositing even after we restored the original throttling state when the chat requests ended. I will use this setting as a first step to either confirm or eliminate the chat customization as a source of the issue and then proceed to get additional diagnostics from the runtime.