fix: ensure refresh settings tree even if context view focused#278537
Open
mortalYoung wants to merge 1 commit intomicrosoft:mainfrom
Open
fix: ensure refresh settings tree even if context view focused#278537mortalYoung wants to merge 1 commit intomicrosoft:mainfrom
mortalYoung wants to merge 1 commit intomicrosoft:mainfrom
Conversation
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @rzhao271Matched files:
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where the settings tree wouldn't refresh when a context view (such as a dropdown or autocomplete widget) had focus. The fix removes unnecessary code that was deferring refresh operations in this scenario.
- Removes the context view focus check that was blocking settings tree refreshes
- Removes the unused
contextViewFocused()helper method - Ensures settings always refresh appropriately while maintaining protection for focused setting controls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove unnecessarily code to make sure always refresh settings tree.
Changes
I checked the git blame and found these code were committed in d59d014
And I cannot reproduce the issue related in this commit after removing these code.
Related
Fixed #277787