fix: possible memory leak with decoration registration#278331
Merged
hediet merged 1 commit intomicrosoft:mainfrom Nov 24, 2025
Merged
fix: possible memory leak with decoration registration#278331hediet merged 1 commit intomicrosoft:mainfrom
hediet merged 1 commit intomicrosoft:mainfrom
Conversation
hediet
approved these changes
Nov 24, 2025
Member
|
Thank you! |
Tyriar
approved these changes
Nov 24, 2025
mjbvz
approved these changes
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a few possible memory leaks with decoration registration by registering the returned disposable.
Details
Currently decorations are registered like this:
But it can be easy to forget that most likely the decoration also needs to be removed on dispose:
Change
The change is to switch to using
this._register, which seems to make it easier to register the decoration as a disposable. Now for example incommentsControllerorbreakPointWidgetthe decoration registration is registered as a disposable.